-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(htmltoslate): shadowed variable #42
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions bot
pushed a commit
to cloudbeds/slate-serializers
that referenced
this pull request
Mar 17, 2023
# 1.0.0 (2023-03-17) ### Bug Fixes * **ci:** artifact path ([f7c4add](f7c4add)) * error when parsing empty or self-closing tags ([thompsonsj#23](https://github.com/cloudbeds/slate-serializers/issues/23)) ([8adb74b](8adb74b)) * **html-to-slate:** prevent adding excessive line break when <br> is happen to be within text nodes ([5762c61](5762c61)) * **html-to-slate:** trim whitespace that precedes a block element ([a2eb943](a2eb943)) * **html-to-slate:** trim whitespace that precedes a block element ([thompsonsj#38](https://github.com/cloudbeds/slate-serializers/issues/38)) ([74f3d24](74f3d24)) * **htmltoslate:** ensure empty children have a text node ([thompsonsj#21](https://github.com/cloudbeds/slate-serializers/issues/21)) ([59ac5b9](59ac5b9)) * **htmltoslate:** htmlToSlate function add return type ([thompsonsj#43](https://github.com/cloudbeds/slate-serializers/issues/43)) ([thompsonsj#45](https://github.com/cloudbeds/slate-serializers/issues/45)) ([9ee52a5](9ee52a5)) * **htmltoslate:** shadowed variable ([thompsonsj#42](https://github.com/cloudbeds/slate-serializers/issues/42)) ([aa7ee16](aa7ee16)) * **package.json:** downgrade htmlparser2 for Webpack 4 compatibility ([thompsonsj#49](https://github.com/cloudbeds/slate-serializers/issues/49)) ([47bc3b0](47bc3b0)) * **readme.md:** apply corrections ([thompsonsj#11](https://github.com/cloudbeds/slate-serializers/issues/11)) ([e12d933](e12d933)) * **slatetodom:** parseDocument argument type ([thompsonsj#50](https://github.com/cloudbeds/slate-serializers/issues/50)) ([db8d566](db8d566)) * **slatetohtml:** do not add an empty style attribute ([thompsonsj#20](https://github.com/cloudbeds/slate-serializers/issues/20)) ([a303806](a303806)) * **slatetohtml:** do not escape html entities ([thompsonsj#16](https://github.com/cloudbeds/slate-serializers/issues/16)) ([4d25706](4d25706)) * **slatetohtml:** return an empty document if no Slate object ([thompsonsj#51](https://github.com/cloudbeds/slate-serializers/issues/51)) ([42a1e7a](42a1e7a)) * **src:** folder capitalisation ([thompsonsj#47](https://github.com/cloudbeds/slate-serializers/issues/47)) ([90a61e4](90a61e4)) * **src:** remove unused directories ([thompsonsj#48](https://github.com/cloudbeds/slate-serializers/issues/48)) ([4717128](4717128)) * **update-html:** import ([2ae2af8](2ae2af8)) ### Features * ***to*:** handle html entities appropriately ([thompsonsj#22](https://github.com/cloudbeds/slate-serializers/issues/22)) ([2cd5ce1](2cd5ce1)) * ***to*:** html manipulation capabilities ([thompsonsj#19](https://github.com/cloudbeds/slate-serializers/issues/19)) ([341cf32](341cf32)) * **config:** extract and make customizable ([thompsonsj#10](https://github.com/cloudbeds/slate-serializers/issues/10)) ([2ea995e](2ea995e)) * **defaulttag:** replace enforceTopLevelPTags ([thompsonsj#13](https://github.com/cloudbeds/slate-serializers/issues/13)) ([e144e03](e144e03)) * **htmltoslate:** process whitespace depending on context ([thompsonsj#18](https://github.com/cloudbeds/slate-serializers/issues/18)) ([0c9feac](0c9feac)) * **htmltoslate:** support line breaks ([#6](#6)) ([fe98bfb](fe98bfb)) * **serializers:** htmlToSlate and slateToHtml ([#1](#1)) ([bc58250](bc58250)) * **serializers:** support more HTML tags ([#2](#2)) ([84a09a8](84a09a8)) * **slatetohtml:** control html entity encoding ([thompsonsj#17](https://github.com/cloudbeds/slate-serializers/issues/17)) ([1f660b3](1f660b3)) * **slatetohtml:** convert line breaks to br tags ([thompsonsj#33](https://github.com/cloudbeds/slate-serializers/issues/33)) ([fe080fb](fe080fb)) * **slatetohtml:** improve text tag support ([#3](#3)) ([44d45b6](44d45b6)) * **slatetohtml:** support newtab links ([#5](#5)) ([ef8d004](ef8d004)) * support custom attributes ([#7](#7)) ([2192b0e](2192b0e)) ### Reverts * Revert "refactor(config): extend all config from a sensible default (thompsonsj#26)" (thompsonsj#27) ([e253c4e](e253c4e)), closes [thompsonsj#26](https://github.com/cloudbeds/slate-serializers/issues/26) [thompsonsj#27](https://github.com/cloudbeds/slate-serializers/issues/27)
hygorzorak
pushed a commit
to cloudbeds/slate-serializers
that referenced
this pull request
Oct 16, 2023
* **ci:** artifact path ([f7c4add](f7c4add)) * error when parsing empty or self-closing tags ([thompsonsj#23](https://github.com/cloudbeds/slate-serializers/issues/23)) ([8adb74b](8adb74b)) * **html-to-slate:** prevent adding excessive line break when <br> is happen to be within text nodes ([5762c61](5762c61)) * **html-to-slate:** trim whitespace that precedes a block element ([a2eb943](a2eb943)) * **html-to-slate:** trim whitespace that precedes a block element ([thompsonsj#38](https://github.com/cloudbeds/slate-serializers/issues/38)) ([74f3d24](74f3d24)) * **htmltoslate:** ensure empty children have a text node ([thompsonsj#21](https://github.com/cloudbeds/slate-serializers/issues/21)) ([59ac5b9](59ac5b9)) * **htmltoslate:** htmlToSlate function add return type ([thompsonsj#43](https://github.com/cloudbeds/slate-serializers/issues/43)) ([thompsonsj#45](https://github.com/cloudbeds/slate-serializers/issues/45)) ([9ee52a5](9ee52a5)) * **htmltoslate:** shadowed variable ([thompsonsj#42](https://github.com/cloudbeds/slate-serializers/issues/42)) ([aa7ee16](aa7ee16)) * **package.json:** downgrade htmlparser2 for Webpack 4 compatibility ([thompsonsj#49](https://github.com/cloudbeds/slate-serializers/issues/49)) ([47bc3b0](47bc3b0)) * **readme.md:** apply corrections ([thompsonsj#11](https://github.com/cloudbeds/slate-serializers/issues/11)) ([e12d933](e12d933)) * **slatetodom:** parseDocument argument type ([thompsonsj#50](https://github.com/cloudbeds/slate-serializers/issues/50)) ([db8d566](db8d566)) * **slatetohtml:** do not add an empty style attribute ([thompsonsj#20](https://github.com/cloudbeds/slate-serializers/issues/20)) ([a303806](a303806)) * **slatetohtml:** do not escape html entities ([thompsonsj#16](https://github.com/cloudbeds/slate-serializers/issues/16)) ([4d25706](4d25706)) * **slatetohtml:** return an empty document if no Slate object ([thompsonsj#51](https://github.com/cloudbeds/slate-serializers/issues/51)) ([42a1e7a](42a1e7a)) * **src:** folder capitalisation ([thompsonsj#47](https://github.com/cloudbeds/slate-serializers/issues/47)) ([90a61e4](90a61e4)) * **src:** remove unused directories ([thompsonsj#48](https://github.com/cloudbeds/slate-serializers/issues/48)) ([4717128](4717128)) * **update-html:** import ([2ae2af8](2ae2af8)) * ***to*:** handle html entities appropriately ([thompsonsj#22](https://github.com/cloudbeds/slate-serializers/issues/22)) ([2cd5ce1](2cd5ce1)) * ***to*:** html manipulation capabilities ([thompsonsj#19](https://github.com/cloudbeds/slate-serializers/issues/19)) ([341cf32](341cf32)) * **config:** extract and make customizable ([thompsonsj#10](https://github.com/cloudbeds/slate-serializers/issues/10)) ([2ea995e](2ea995e)) * **defaulttag:** replace enforceTopLevelPTags ([thompsonsj#13](https://github.com/cloudbeds/slate-serializers/issues/13)) ([e144e03](e144e03)) * **htmltoslate:** process whitespace depending on context ([thompsonsj#18](https://github.com/cloudbeds/slate-serializers/issues/18)) ([0c9feac](0c9feac)) * **htmltoslate:** support line breaks ([#6](#6)) ([fe98bfb](fe98bfb)) * **serializers:** htmlToSlate and slateToHtml ([#1](#1)) ([bc58250](bc58250)) * **serializers:** support more HTML tags ([#2](#2)) ([84a09a8](84a09a8)) * **slatetohtml:** control html entity encoding ([thompsonsj#17](https://github.com/cloudbeds/slate-serializers/issues/17)) ([1f660b3](1f660b3)) * **slatetohtml:** convert line breaks to br tags ([thompsonsj#33](https://github.com/cloudbeds/slate-serializers/issues/33)) ([fe080fb](fe080fb)) * **slatetohtml:** improve text tag support ([#3](#3)) ([44d45b6](44d45b6)) * **slatetohtml:** support newtab links ([#5](#5)) ([ef8d004](ef8d004)) * support custom attributes ([#7](#7)) ([2192b0e](2192b0e)) * Revert "refactor(config): extend all config from a sensible default (thompsonsj#26)" (thompsonsj#27) ([e253c4e](e253c4e)), closes [thompsonsj#26](https://github.com/cloudbeds/slate-serializers/issues/26) [thompsonsj#27](https://github.com/cloudbeds/slate-serializers/issues/27)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.