Skip to content
This repository has been archived by the owner on Oct 10, 2023. It is now read-only.

Update dependencies 15-09-2020 #458

Closed
wants to merge 2 commits into from
Closed

Conversation

veado
Copy link
Collaborator

@veado veado commented Sep 15, 2020

tl;dr

This update failed due several dependency issues and will be postponed until react-scripts supports typescript@4

Available updates

ncu
Checking asgardex-electron/package.json
[====================] 89/89 100%

 @ant-design/icons                           ^4.2.1  →         ^4.2.2   
 @devexperts/remote-data-ts                  ^2.0.3  →         ^2.0.4   
 @openapitools/openapi-generator-cli  ^1.0.15-4.3.1  →  ^1.0.18-4.3.1   
 antd                                        ^4.6.1  →         ^4.6.4   
 electron-log                                ^4.2.2  →         ^4.2.4   
 ethers                                      ^5.0.9  →        ^5.0.13   
 fp-ts                                       ^2.8.1  →         ^2.8.2   
 observable-hooks                            ^3.0.0  →         ^3.1.2   
 react-intl                                  ^5.4.5  →         ^5.8.1   
 react-scripts                                3.4.1  →          3.4.3   
 rxjs                                        ^6.6.2  →         ^6.6.3   
 styled-components                           ^5.1.1  →         ^5.2.0   
 typescript                                  ^3.9.7  →         ^4.0.2   
 @storybook/addon-actions                   ^5.3.19  →        ^6.0.21   
 @storybook/addon-knobs                     ^5.3.19  →        ^6.0.21   
 @storybook/addon-links                     ^5.3.19  →        ^6.0.21   
 @storybook/addon-viewport                  ^5.3.19  →        ^6.0.21   
 @storybook/addons                          ^5.3.19  →        ^6.0.21   
 @storybook/react                           ^5.3.19  →        ^6.0.21   
 @storybook/theming                         ^5.3.19  →        ^6.0.21   
 @testing-library/jest-dom                  ^5.11.2  →        ^5.11.4   
 @testing-library/react                     ^10.4.7  →        ^11.0.4   
 @testing-library/user-event                ^12.1.0  →        ^12.1.5   
 @types/jest                                ^26.0.8  →       ^26.0.13   
 @types/node                                    ^13  →            ^14   
 @types/react                              ^16.9.44  →       ^16.9.49   
 @types/styled-components                    ^5.1.2  →         ^5.1.3   
 @typescript-eslint/eslint-plugin            ^3.7.1  →         ^4.1.1   
 @typescript-eslint/parser                   ^3.7.1  →         ^4.1.1   
 concurrently                                ^5.2.0  →         ^5.3.0   
 electron                                    ^9.1.2  →        ^10.1.2   
 eslint-plugin-react                        ^7.20.5  →        ^7.20.6   
 eslint-plugin-react-hooks                   ^4.0.8  →         ^4.1.2   
 husky                                       ^4.2.5  →         ^4.3.0   
 lint-staged                               ^10.2.11  →        ^10.3.0   
 prettier                                    ^2.0.5  →         ^2.1.1   
 testcafe                                    ^1.8.8  →         ^1.9.2   
 ts-jest                                    ^26.1.4  →        ^26.3.0   
 ts-loader                                   ^8.0.2  →         ^8.0.3   
 ts-node                                    ^8.10.2  →         ^9.0.0   
 wait-on                                     ^5.1.0  →         ^5.2.0  

Issues

(1) typescript@4.x is not fully supported by latest react-scripts@3.4.3 (facebook/create-react-app#9515). It causes eslint issues and needs to be updated to latest @typescript-eslint/eslint-plugin@4.x before. This needed change is already in master (facebook/create-react-app#9434), but not published yet.

(2) testcafe does not support electron@10.x. we will still stick with electron@9.x.

(3) Update to latest fp-ts@2.8.2 failed, it introduces type errors by using @devexperts/remote-data-ts@2.0.4

asgardex-electron/src/renderer/helpers/fpHelpers.ts
[dev:app] TypeScript error in asgardex-electron/src/renderer/helpers/fpHelpers.ts(18,38):
[dev:app] No overload matches this call.
[dev:app]   The last overload gave the following error.
[dev:app]     Argument of type 'Monad2<"RemoteData"> & Foldable2<"RemoteData"> & Traversable2<"RemoteData"> & Bifunctor2<"RemoteData"> & Alt2<"RemoteData"> & Extend2<...> & Alternative2<...>' is not assignable to parameter of type 'Apply<"RemoteData">'.
[dev:app]       Types of property 'ap' are incompatible.
[dev:app]         Type '<E, A, B>(fab: RemoteData<E, (a: A) => B>, fa: RemoteData<E, A>) => RemoteData<E, B>' is not assignable to type '<A, B>(fab: HKT<"RemoteData", (a: A) => B>, fa: HKT<"RemoteData", A>) => HKT<"RemoteData", B>'.
[dev:app]           Types of parameters 'fab' and 'fab' are incompatible.
[dev:app]             Type 'HKT<"RemoteData", (a: A) => B>' is not assignable to type 'RemoteData<unknown, (a: unknown) => unknown>'.
[dev:app]               Type 'HKT<"RemoteData", (a: A) => B>' is missing the following properties from type 'RemoteSuccess<(a: unknown) => unknown>': _tag, value  TS2769
[dev:app] 
[dev:app]     16 |   return sequenceTOption(first, ...rest)
[dev:app]     17 | }
[dev:app]   > 18 | export const sequenceTRD = sequenceT(RD.remoteData)
[dev:app]        |                                      ^
[dev:app]     19 | export const sequenceTRDFromArray = <E, A>(onEmpty: () => E) => ([first, ...rest]: RD.RemoteData<

^ These errors are very similar as described in devexperts/remote-data-ts#49

Due lack of time we will stick on fp-ts@2.8.1 for now.

@veado veado self-assigned this Sep 15, 2020
@veado veado marked this pull request as draft September 15, 2020 14:09
veado added a commit that referenced this pull request Sep 16, 2020
to avoid issues we have had in #458
@veado veado mentioned this pull request Sep 16, 2020
3 tasks
@veado
Copy link
Collaborator Author

veado commented Sep 16, 2020

We will give another try when react-scripts supports typescript@4.x. Closing now...

@veado veado closed this Sep 16, 2020
@veado veado deleted the issue/update-deps-150920 branch September 16, 2020 07:22
veado added a commit that referenced this pull request Sep 16, 2020
to avoid issues we have had in #458.

- [x]  Remove `fp-ts` dependency. It's already provided by `@devexperts/remote-data-ts` and might cause issues using different versions of `fp-ts`. 
- [x] Remove misc. `eslint` packages which are already provided by `react-scripts`. It might cause issues while having different versions of these packages.
- [x] Bump to 0.0.3-alpha.1
veado added a commit that referenced this pull request Sep 16, 2020
luxuereal added a commit to luxuereal/wallet-Asgardex-electron that referenced this pull request Jun 16, 2023
to avoid issues we have had in thorchain/asgardex-electron#458.

- [x]  Remove `fp-ts` dependency. It's already provided by `@devexperts/remote-data-ts` and might cause issues using different versions of `fp-ts`. 
- [x] Remove misc. `eslint` packages which are already provided by `react-scripts`. It might cause issues while having different versions of these packages.
- [x] Bump to 0.0.3-alpha.1
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant