Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace use of AtomicU64 with AtomicUsize. #28

Merged
merged 4 commits into from
Mar 15, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 6 additions & 6 deletions Cargo.toml
Original file line number Diff line number Diff line change
Expand Up @@ -13,15 +13,15 @@ readme = "README.md"
repository = "https://github.com/thoren-d/tracing-chrome"

[dependencies]
serde_json = "1.0.91"
tracing-core = "0.1.30"
tracing-subscriber = "0.3.16"
serde_json = "1.0.114"
tracing-core = "0.1.32"
tracing-subscriber = "0.3.18"


[dev-dependencies]
criterion = "0.4.0"
rayon = "1.5.3"
tracing = "0.1.37"
criterion = "0.5.1"
rayon = "1.9.0"
tracing = "0.1.40"


[[bench]]
Expand Down
25 changes: 13 additions & 12 deletions src/lib.rs
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ use std::{
marker::PhantomData,
path::Path,
sync::{
atomic::{AtomicU64, Ordering},
atomic::{AtomicUsize, Ordering},
Arc, Mutex,
},
};
Expand All @@ -26,8 +26,8 @@ use std::{
};

thread_local! {
static OUT: RefCell<Option<Sender<Message>>> = RefCell::new(None);
static TID: RefCell<Option<u64>> = RefCell::new(None);
static OUT: RefCell<Option<Sender<Message>>> = const { RefCell::new(None) };
static TID: RefCell<Option<usize>> = const { RefCell::new(None) };
}

type NameFn<S> = Box<dyn Fn(&EventOrSpan<'_, '_, S>) -> String + Send + Sync>;
Expand All @@ -40,7 +40,7 @@ where
{
out: Arc<Mutex<Sender<Message>>>,
start: std::time::Instant,
max_tid: AtomicU64,
max_tid: AtomicUsize,
include_args: bool,
include_locations: bool,
trace_style: TraceStyle,
Expand Down Expand Up @@ -88,7 +88,7 @@ where
include_args: false,
include_locations: true,
trace_style: TraceStyle::Threaded,
_inner: PhantomData::default(),
_inner: PhantomData,
}
}

Expand Down Expand Up @@ -240,7 +240,7 @@ impl Drop for FlushGuard {
}

struct Callsite {
tid: u64,
tid: usize,
name: String,
target: String,
file: Option<&'static str>,
Expand All @@ -252,7 +252,7 @@ enum Message {
Enter(f64, Callsite, Option<u64>),
Event(f64, Callsite),
Exit(f64, Callsite, Option<u64>),
NewThread(u64, String),
NewThread(usize, String),
Flush,
Drop,
StartNew(Option<Box<dyn Write + Send>>),
Expand Down Expand Up @@ -297,7 +297,7 @@ where
write.write_all(b"[\n").unwrap();

let mut has_started = false;
let mut thread_names: Vec<(u64, String)> = Vec::new();
let mut thread_names: Vec<(usize, String)> = Vec::new();
for msg in rx {
if let Message::Flush = &msg {
write.flush().unwrap();
Expand Down Expand Up @@ -407,19 +407,19 @@ where
let layer = ChromeLayer {
out: Arc::new(Mutex::new(tx)),
start: std::time::Instant::now(),
max_tid: AtomicU64::new(0),
max_tid: AtomicUsize::new(0),
name_fn: builder.name_fn.take(),
cat_fn: builder.cat_fn.take(),
include_args: builder.include_args,
include_locations: builder.include_locations,
trace_style: builder.trace_style,
_inner: PhantomData::default(),
_inner: PhantomData,
};

(layer, guard)
}

fn get_tid(&self) -> (u64, bool) {
fn get_tid(&self) -> (usize, bool) {
TID.with(|value| {
let tid = *value.borrow();
match tid {
Expand Down Expand Up @@ -454,7 +454,8 @@ where
EventOrSpan::Span(s) => s
.extensions()
.get::<ArgsWrapper>()
.map(|e| Arc::clone(&e.args)),
.map(|e| &e.args)
.cloned(),
};
let name = name.unwrap_or_else(|| meta.name().into());
let target = target.unwrap_or_else(|| meta.target().into());
Expand Down
Loading