Tag creation in kebechet with release option #1058
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sesheta
added
the
size/M
harshad16
requested changes
Jun 8, 2022
harshad16
requested changes
Jun 8, 2022
There was a problem hiding this comment.
pre-commit check is failing due to following:
fix end of files.........................................................Failed
- hook id: end-of-file-fixer
- exit code: 1
- files were modified by this hook
Fixing kebechet/managers/version/utils.py
Fixing kebechet/managers/version/version.py
mypy.....................................................................Failed
- hook id: mypy
- exit code: 1
kebechet/managers/version/utils.py:223: error: Item "None" of "Optional[Match[Any]]" has no attribute "group"
Found 1 error in 1 file (checked 37 source files)
black....................................................................Failed
- hook id: black
- files were modified by this hook
reformatted kebechet/managers/version/utils.py
reformatted kebechet/managers/version/version.py
this can be viewed from details button on the failed check
please address the following
|
Hey @shreekarSS, to comply with formatting standards you can run the follwing commands:
To have this run on your local repo before every commit you can run |
_get_merge_commit_sha() -> to get merge commit sha
_get_version() -> Get version from PR branch
_is_release_version_pr -> Check if PR is open khebhut bot and is release PR or not
Signed-off-by: Shreekar <sshreeka@redhat.com>
shreekarSS
force-pushed
the
tag_creation_kebechet
branch
2 times, most recently
from
5af454e
to
da40513
Compare
shreekarSS
force-pushed
the
tag_creation_kebechet
branch
from
da40513
to
37a3cdf
Compare
Signed-off-by: Shreekar <sshreeka@redhat.com>
shreekarSS
force-pushed
the
tag_creation_kebechet
branch
from
37a3cdf
to
a3edba2
Compare
shreekarSS
added a commit
to shreekarSS/kebechet
that referenced
this pull request
Jun 10, 2022
Signed-off-by: Shreekar <sshreeka@redhat.com>
Signed-off-by: Shreekar <sshreeka@redhat.com>
shreekarSS
force-pushed
the
tag_creation_kebechet
branch
from
d861dd6
to
65f2936
Compare
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: harshad16 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
sesheta
added
the
approved
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues and Dependencies
Include tag creation in kebechet with release option [https://github.com//issues/1056]
…
This introduces a breaking change
This Pull Request implements
Creation a tag on the merge of the release pull request created by kebechet.