DST Fixes #4
Merged
DST Fixes #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Since we are cherry-picking fix strategies, let's make a comment/ description on the PR on where this came from. |
MikeZLin
reviewed
Feb 14, 2023
cronexpr.go
Outdated
| i := sort.SearchInts(expr.yearList, v) | ||
| if i == len(expr.yearList) { | ||
| loc := fromTime.Location() | ||
| t := fromTime.Add(time.Second - time.Duration(fromTime.Nanosecond())*time.Nanosecond) |
There was a problem hiding this comment.
could truncate to time.Nanosecond here i guess
There was a problem hiding this comment.
Well they are rounding up - so I've moved the logic to a method explaining it.
All hell breaks loose if I truncate to nanosec.
cronexpr.go
Outdated
|
|
||
| WRAP: | ||
|
|
||
| // let's find the next date that satisfies condition |
There was a problem hiding this comment.
probs worth keeping the comment string
cronexpr_test.go
Outdated
| require.Equal(t, expectedTm, resultTm, test) | ||
|
|
||
| //if expr.Next(from).UTC() != to.UTC() { | ||
| // t.Errorf("Expected Next time to be %s from %s in %s, when actually %s; UTC FROM %s, UTC TO:%s ", to, from, test.where, expr.Next(from), from.UTC(), expr.Next(from).UTC()) |
| {"2019-11-03 02:30:00", "2019-11-04T02:30:00-08:00", "America/Los_Angeles"}, | ||
| {"2019-03-09 02:30:00", "2019-03-10T03:30:00-07:00", "US/Pacific"}, | ||
| {"2019-03-09 02:30:00", "2019-03-11T03:30:00-06:00", "US/Pacific"}, // Note that 02:30am on the 10th doesn't exist due to DST |
There was a problem hiding this comment.
since san paulo was referenced in the code, lets make a test case for this
naimulhaider
force-pushed
the
fix/timezone_fix
branch
from
10f3092 to
3dc2267
Compare
MikeZLin
approved these changes
Feb 14, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry picked DST fixes from https://github.com/hashicorp/cronexpr/tree/b-dst-fix