Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automatically push docker images during release CI/CD #60

Merged
merged 2 commits into from
Oct 19, 2020

Conversation

VJftw
Copy link
Contributor

@VJftw VJftw commented Oct 18, 2020

This PR adds the ./pleasew run //scripts:publish-images to the release workflow so that Docker images are automatically pushed via CI/CD for each release. I have added the following secrets to the repository's actions for this to work:

From the "Secrets" page in "Settings" for this repository:

Secrets are environment variables that are encrypted and only exposed to selected actions. Anyone with collaborator access to this repository can use these secrets in a workflow.
Secrets are not passed to workflows that are triggered by a pull request from a fork.

Copy link
Contributor

@northdpole northdpole left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good stuff, we needed this :D

@VJftw VJftw requested a review from northdpole October 18, 2020 23:52
@VJftw
Copy link
Contributor Author

VJftw commented Oct 18, 2020

sorry, thought it would be best to test the entire cycle on my https://github.com/VJftw/docker-registry-proxy project first and discovered that we need to run git fetch --tags --force on GitHub Actions workers as a workaround for not having all the tags (see actions/checkout#290). This works as expected now. I think in the future, we could remove the on.push.branches: [master] if the releases get a bit too spammy - but we can decide in the future

@VJftw VJftw merged commit b709e8c into master Oct 19, 2020
@VJftw VJftw deleted the cicd-push-images branch October 19, 2020 11:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants