Allow API endpoints to determine default boolean option values #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RichardoC
approved these changes
Feb 23, 2024
On Jira API endpoints that accept boolean parameters, the value of the parameter may default to either true or false if it isn't supplied in the request, depending on the endpoint. In options structs that have them, change the type of fields representing these parameters from `bool` to `*bool`, so that their value isn't explicitly set to false in the request if a value isn't given in the struct - in order words, let the API endpoint decide what the value should be, not go-jira.
chrisnovakovic
force-pushed
the
tristate-bool-notifyusers
branch
from
ab54a10 to
7ffee35
Compare
|
Good idea - I've widened this to cover all bools in options structs, not just |
chrisnovakovic
changed the title
notifyUsers option value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On Jira API endpoints that accept boolean parameters, the value of the parameter may default to either true or false if it isn't supplied in the request, depending on the endpoint. In options structs that have them, change the type of fields representing these parameters from
boolto*bool, so that their value isn't explicitly set to false in the request if a value isn't given in the struct - in order words, let the API endpoint decide what the value should be, not go-jira.