Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add link to generate a virtual env under plz-out #2210

Merged
merged 2 commits into from
Dec 8, 2021

Conversation

Tatskaari
Copy link
Member

No description provided.

@Tatskaari Tatskaari requested a review from peterebden December 1, 2021 18:35
@Tatskaari Tatskaari changed the title Add link to generate a virtual env under Add link to generate a virtual env under plz-out Dec 2, 2021
Copy link
Contributor

@samwestmoreland samwestmoreland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How come one's a dlink and the other a link? Is it something about retaining the directory structure?

@Tatskaari
Copy link
Member Author

Tatskaari commented Dec 7, 2021

How come one's a dlink and the other a link? Is it something about retaining the directory structure?

The srcs rules output files in slightly different ways. The wheel rules produce {module}/thing.py whereas the pip rules produce {name}/{module}/thing.py.

The dlink label removes the extra level of nesting.

@Tatskaari Tatskaari merged commit 0230a43 into thought-machine:master Dec 8, 2021
@afterthought
Copy link
Contributor

@Tatskaari, I tested this and it doesn't quite work. Only 1 pip_library gets linked to python/venv and then the remaining ones are skipped because this line is checking if the destination exists and it does already after the first lib creates python/venv.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants