Skip to content
This repository has been archived by the owner on Jul 17, 2023. It is now read-only.

Requirements fails when package has "extras" #48

Closed
andrew-womeldorf opened this issue Aug 12, 2020 · 0 comments · Fixed by #49
Closed

Requirements fails when package has "extras" #48

andrew-womeldorf opened this issue Aug 12, 2020 · 0 comments · Fixed by #49

Comments

@andrew-womeldorf
Copy link
Contributor

It's fairly common practice with Python packages to build packages with square brackets [...] for a variation of a package to support something extra. For example, the passlib package has optional library support that can be included when installing by adding the library name in brackets to the package name: passlib[argon2].

However, it appears that the square brackets are not supported names for a build_rule:

python/requirements.build_defs:52:18: error: Invalid build target name _passlib[argon2]#wheel

    wheel_rule = build_rule(
                 ^
        name = name,

Traceback:
python/requirements.build_defs:52:18:       wheel_rule = build_rule(

python/requirements.build_defs:14:55:           post_build = lambda _, output: [add_dep(name, auto_pip_library(
                              : 0: 0:   <source unavailable>
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant