Skip to content
This repository has been archived by the owner on Jul 17, 2023. It is now read-only.

Allow installation of python packages with extras #49

Merged
merged 1 commit into from
Feb 24, 2021
Merged

Allow installation of python packages with extras #49

merged 1 commit into from
Feb 24, 2021

Conversation

andrew-womeldorf
Copy link
Contributor

@andrew-womeldorf andrew-womeldorf commented Aug 12, 2020 •
edited
Loading

closes #48

@andrew-womeldorf
Copy link
Contributor Author

This replaces the typical square brackets around package extras with an underscore separator for just the name. The package should continue to have the square brackets, since the package passlib[argon2] is just a string to look up in pypi:

name: passlib[argon2] --> passlib_argon2
package: passlib[argon2]

@andrew-womeldorf andrew-womeldorf force-pushed the issue/48-python-requirement-extras branch from c7911c6 to e852e3c Compare August 17, 2020 20:43
@afterthought
Copy link
Contributor

Anxious to see this merged.

@Tatskaari
Copy link
Member

I'm really sorry guys. I had my notification settings wrong and totally missed this. Looks good to me. Landing.

@Tatskaari Tatskaari merged commit 841482e into thought-machine:master Feb 24, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Requirements fails when package has "extras"
3 participants
@andrew-womeldorf @afterthought @Tatskaari