This repository has been archived by the owner on Jul 17, 2023. It is now read-only.
Fix #57 docker fqn replace with --arch on macOS #58
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Whilst using --arch to cross compile binaries for particular docker images on macOS, the docker image fqn would not be replaced in a k8s template. By switching CONFIG.OS to CONFIG.HOSTOS we cannot override the OS sed command using --arch.
|
Makes sense and many thanks for this! Apologies on the slow response... my notification settings were wrong and I didn't see this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whilst using --arch to cross compile binaries for particular docker images on macOS, the docker image fqn would not be replaced in a k8s template.
By switching CONFIG.OS to CONFIG.HOSTOS we cannot override the OS sed command using --arch.