This repository has been archived by the owner on Jul 17, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 39
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
VJftw
commented
Feb 12, 2021
VJftw
commented
Feb 12, 2021
VJftw
commented
Feb 12, 2021
VJftw
commented
Feb 12, 2021
VJftw
commented
Feb 12, 2021
I'm so sorry I did see these until now :S Not sure why I didn't get emailed about this... maybe I'm not following this repo correctly. Will have a look ASAP. |
Thanks VJ. I'm not very clued up with terraform but these looks like they could be useful to a lot of people. I'll merge them, as this repo is becoming more of a jumping off point or implementing your own rules rather than a well supported set of rules. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
👋 , I'd started some Terraform build_defs previously for my personal website infrastructure so I've some time formalising them a lot more, and I'm actively using them in my personal infrastructure.
Question:
You'll notice that I've split out a lot of the bash into the
//terraform/scripts/
directory, which results in end-users needing additionalremote_file
s for them (example) as well as the usualremote_file
for the build_def (example).Is this an okay thing to do? I feel it's a bit more painful for end-users, but I do like that the bash scripts are much more maintainable. Do you know of any better ways I could keep the bash scripts maintainable but with less end-user setup burden?
I've also added some examples in
//terraform/examples/...
which are tested in the GitHub actions.I'll share this with the wider team to get feedback too :)