Skip to content
This repository has been archived by the owner on Jul 17, 2023. It is now read-only.

Terraform build_defs #59

Merged
merged 12 commits into from
Mar 18, 2021
Merged

Terraform build_defs #59

merged 12 commits into from
Mar 18, 2021

Conversation

VJftw
Copy link
Contributor

@VJftw VJftw commented Feb 12, 2021

👋 , I'd started some Terraform build_defs previously for my personal website infrastructure so I've some time formalising them a lot more, and I'm actively using them in my personal infrastructure.

Question:
You'll notice that I've split out a lot of the bash into the //terraform/scripts/ directory, which results in end-users needing additional remote_files for them (example) as well as the usual remote_file for the build_def (example).
Is this an okay thing to do? I feel it's a bit more painful for end-users, but I do like that the bash scripts are much more maintainable. Do you know of any better ways I could keep the bash scripts maintainable but with less end-user setup burden?

I've also added some examples in //terraform/examples/... which are tested in the GitHub actions.

I'll share this with the wider team to get feedback too :)

terraform/README.md Outdated Show resolved Hide resolved
terraform/README.md Outdated Show resolved Hide resolved
terraform/README.md Outdated Show resolved Hide resolved
@Tatskaari
Copy link
Member

I'm so sorry I did see these until now :S

Not sure why I didn't get emailed about this... maybe I'm not following this repo correctly. Will have a look ASAP.

@Tatskaari Tatskaari self-requested a review February 24, 2021 19:46
@Tatskaari
Copy link
Member

Thanks VJ. I'm not very clued up with terraform but these looks like they could be useful to a lot of people. I'll merge them, as this repo is becoming more of a jumping off point or implementing your own rules rather than a well supported set of rules.

@Tatskaari Tatskaari merged commit 675732a into thought-machine:master Mar 18, 2021
@VJftw VJftw deleted the terraform branch November 2, 2021 19:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants