Support for decoding UInt and UInt64 #396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -36,6 +36,9 @@ struct TestModelNumerics { | |||
| let double: Double | |||
| let float: Float | |||
| let intOpt: Int? | |||
|
|
|||
There was a problem hiding this comment.
Trailing Whitespace Violation: Lines should not have trailing whitespace. (trailing_whitespace)
gcox
changed the title
gcox
force-pushed
the
unsigned-integer-support
branch
from
0dc5879
to
0fea858
Compare
|
I'm happy to redo this change on the Swift-2.3 branch if it should go there first |
|
You can get around the "too complex" errors by breaking the |
|
Neat, thanks! I think we could merge this into master and then I'll cherry-pick it into a new release for 2.3 since there's no reason not to backport it. |
|
I worked around the too complex issues and merged this into master. I'm also cutting 3.1 with this change in it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tried to update the
TestModelNumericsstruct cleanly but ran into the "Expression was too complex to be solved in reasonable time" bug in Swift after I added the 3 required properties to the existing struct. That's why I added theTestModelUnsignedNumericsstruct.