Extract image field into a separate gem

Feature: **When I** have a custom field type that I want to share with others, **I want to** reference an official template for a field gem **so I can** more easily package my field for sharing. Implementation: Create a template for field plugins by extracting the image field into its own gem. This is a breaking change with an easy fix - anybody who uses Image fields will need to add `gem "administrate-field-image"` to their `Gemfile`. The source for the image field gem is up at https://github.com/graysonwright/administrate-field-image.
thoughtbot · Apr 21, 2016 · 12843ef · 12843ef
1 parent 30c8b0a
commit 12843ef
Show file tree

Hide file tree

Showing 9 changed files with 16 additions and 82 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -18,6 +18,13 @@
 
 ### Upcoming Release
 
+* [#476] [CHANGE] Extract `Administrate::Field::Image` into its own gem.
+  Users who have image fields in their dashboards
+  should add to their `Gemfile`:
+  ```ruby
+  gem "administrate-field-image"
+  ```
+
 ### 0.1.5 (April 1, 2016)
 
 * [master] [BUGFIX] Protect from CSRF attacks [CVE-2016-3098]

diff --git a/Gemfile b/Gemfile
@@ -4,6 +4,7 @@ ruby "2.2.3"
 
 gemspec
 
+gem "administrate-field-image", path: "../administrate-field-image"
 gem "delayed_job_active_record"
 gem "high_voltage"
 gem "markdown-rails"

diff --git a/Gemfile.lock b/Gemfile.lock
@@ -1,3 +1,10 @@
+PATH
+  remote: ../administrate-field-image
+  specs:
+    administrate-field-image (0.0.1)
+      administrate (~> 0.1.3)
+      rails (~> 4.2)
+
 PATH
   remote: .
   specs:
@@ -280,6 +287,7 @@ PLATFORMS
 
 DEPENDENCIES
   administrate!
+  administrate-field-image!
   ammeter
   appraisal
   awesome_print

diff --git a/app/views/fields/image/_form.html.erb b/app/views/fields/image/_form.html.erb
diff --git a/app/views/fields/image/_index.html.erb b/app/views/fields/image/_index.html.erb
diff --git a/app/views/fields/image/_show.html.erb b/app/views/fields/image/_show.html.erb
diff --git a/docs/customizing_dashboards.md b/docs/customizing_dashboards.md
@@ -57,7 +57,6 @@ specify, including:
 - `Field::Email`
 - `Field::HasMany`
 - `Field::HasOne`
-- `Field::Image`
 - `Field::Number`
 - `Field::Polymorphic`
 - `Field::Select`

diff --git a/lib/administrate/field/image.rb b/lib/administrate/field/image.rb
diff --git a/spec/lib/fields/image_spec.rb b/spec/lib/fields/image_spec.rb