Skip to content

Commit

Permalink
Move Faker to production group to use on Heroku
Browse files Browse the repository at this point in the history
  • Loading branch information
@c-lliope
c-lliope committed Sep 8, 2016
1 parent 55d0a22 commit 5227c9b
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion Gemfile
View file
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@ gemspec
gem "administrate-field-image"
gem "bourbon", "~> 4.2"
gem "delayed_job_active_record"
gem "faker"
gem "high_voltage"
gem "markdown-rails"
gem "pg"
Expand All @@ -22,7 +23,6 @@ group :development, :test do
gem "byebug"
gem "dotenv-rails"
gem "factory_girl_rails"
gem "faker"
gem "i18n-tasks"
gem "pry-rails"
gem "rspec-rails", "~> 3.4.2"
Expand Down

3 comments on commit 5227c9b

@buren
Copy link
Contributor

@buren buren commented on 5227c9b Sep 8, 2016 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Graysonwright why is faker needed in production on Heroku?

The only references I found were in spec/example_app/db/seeds.rb.

Asking since its not a super lightweight dependency:

$ du -sh lib
944K    lib

Thanks!

@c-lliope
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@buren We need to periodically re-seed the database for http://administrate-prototype.herokuapp.com so the sample data is kept fresh for visitors.

That application runs in the production environment, so we need faker available in production as well in order to run the seeds.

It doesn't seem like the size of the library will have too many adverse effects, because it is only installed for people hosting the demo site. It's not a dependency for Administrate itself.

@buren
Copy link
Contributor

@buren buren commented on 5227c9b Sep 8, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Graysonwright oh yeah you're right! My bad, thank you 👍

Please sign in to comment.