more hound fixes

thoughtbot · Dec 15, 2023 · 6517cc5 · 6517cc5
1 parent 87f0a27
commit 6517cc5
Show file tree

Hide file tree

Showing 3 changed files with 21 additions and 23 deletions.
diff --git a/lib/administrate/base_dashboard.rb b/lib/administrate/base_dashboard.rb
@@ -118,10 +118,10 @@ def item_includes
 
     def item_associations
       attributes = if show_page_attributes.is_a?(Hash)
-        show_page_attributes.values.flatten
-      else
-        show_page_attributes
-      end
+                     show_page_attributes.values.flatten
+                   else
+                     show_page_attributes
+                   end
       attribute_associated attributes
     end
 

diff --git a/spec/example_app/app/dashboards/order_dashboard.rb b/spec/example_app/app/dashboards/order_dashboard.rb
@@ -36,24 +36,22 @@ class OrderDashboard < Administrate::BaseDashboard
   ]
 
   FORM_ATTRIBUTES = {
-    "" => [
-      :customer,
+    "" => %i[customer],
+    "details" => %i[
+      line_items
+      shipped_at
+      payments
     ],
-    "details" => [
-      :line_items,
-      :shipped_at,
-      :payments,
+    "address" => %i[
+      address_line_one
+      address_line_two
+      address_city
+      address_state
+      address_zip
     ],
-    "address" => [
-      :address_line_one,
-      :address_line_two,
-      :address_city,
-      :address_state,
-      :address_zip,
-    ],
-  }
+  }.freeze
   SHOW_PAGE_ATTRIBUTES = FORM_ATTRIBUTES.merge(
     "" => %i[customer created_at updated_at],
     "details" => %i[line_items total_price shipped_at payments],
-  )
+  ).freeze
 end
diff --git a/spec/lib/pages/form_spec.rb b/spec/lib/pages/form_spec.rb
@@ -37,10 +37,10 @@
 
       it "returns the attributes from FORM_ATTRIBUTES_NEW" do
         expect(attributes).to match(
-          { "" => %i[
+          "" => %i[
             order
             product
-          ] },
+          ],
         )
       end
     end
@@ -50,11 +50,11 @@
 
       it "returns the attributes from FORM_ATTRIBUTES_EDIT" do
         expect(attributes).to match(
-          { "" => %i[
+          "" => %i[
             order
             product
             quantity
-          ] },
+          ],
         )
       end
     end