-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Improve spacing around header actions
Problem: When the title of the page is unusually long, it can wrap onto multiple lines. Because the action button is aligned to the bottom of the header, the action button is then shifted downwards. This creates an awkward whitespace on the page, and ruins the alignment. Solution: Align the button and header by their baseline, so the button stays in the same place regardless of whether the header wraps lines. Also, add a margin to the left of the header action buttons, so they can keep a bit of distance from the page header even when the header is unusually long.
- Loading branch information
Showing
6 changed files
with
30 additions
and
17 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,10 +1,14 @@ | ||
.header { | ||
align-items: flex-end; | ||
align-items: baseline; | ||
display: flex; | ||
justify-content: space-between; | ||
margin-bottom: $base-spacing * 2; | ||
|
||
&-heading { | ||
margin-top: 0; | ||
} | ||
|
||
&-actions { | ||
margin-left: $base-spacing; | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters