Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature Request: Clearing Search #121

Closed
ACPK opened this issue Nov 1, 2015 · 5 comments
Closed

Feature Request: Clearing Search #121

ACPK opened this issue Nov 1, 2015 · 5 comments

Comments

@ACPK
Copy link

ACPK commented Nov 1, 2015

I'd love to be able to easily the clear search by (1) deleting the text or (2) clicking an (X). As of right now, a user needs to click the page link in the navbar or remove the params for the URL. The former is my preferred method, but let me know what you think.
@c-lliope
Copy link
Contributor

c-lliope commented Nov 1, 2015

Hey, @ACPK. Thanks for the feedback!

I like the "clicking an (X)" option.

I'm not sure I understand how the "deleting the text" option would work - could you give some detail there? Right now, if you delete the search term and hit enter, it'll also clear the search.

@ACPK
Copy link
Author

ACPK commented Nov 1, 2015

@Graysonwright - "Deleting the text" would use autocomplete. With autocomplete (I should have mentioned this originally), the params are automatically updated when you add or remove characters.

Example (see the default white page you get on Google when you remove ThoughtBot):

https://www.google.com/webhp?sourceid=chrome-instant&ion=1&espv=2&ie=UTF-8#q=thoughtbot

User case:

  1. I see a user with a @thoughtbot.com email and am curious how many other Thoughtbot team members are using my app. Hence, I type "@thoughtbot.com" in the search bar. Now, I see they're five users listed so I quickly backspace through @thoughtbot.com" to see what other company domains I can search for within my application.

@c-lliope
Copy link
Contributor

c-lliope commented Nov 1, 2015

oh, alright.

Automatically searching for the user would be a bit tricky - we would need to reload part of the page while keeping the search bar there. I imagine we could do this with turbolinks, but I'm hesitant to introduce that level of complexity. We would need to be careful that the interaction isn't confusing for people who aren't expecting it, and it would require making a bunch of server requests for each search.

I think an "X" will be the easiest and most effective way to solve this.

@ACPK
Copy link
Author

ACPK commented Nov 2, 2015

@Graysonwright - For now, I agree. Want to do a PR or I can work on it later this week?

c-lliope added a commit that referenced this issue Nov 2, 2015
@c-lliope
Add button to clear search field
107addc 
Closes #121.

Problem:

Users cannot clear their search
unless they re-submit the search with an empty field,
or click on the resource link in the navigation bar.

Solution:

Add a button for clearing out the search field
and going back to showing all resources.
@c-lliope c-lliope mentioned this issue Nov 2, 2015
Merged
@c-lliope
Copy link
Contributor

c-lliope commented Nov 2, 2015

@ACPK I've got it, no worries.

#127

c-lliope added a commit that referenced this issue Nov 6, 2015
@c-lliope
Add button to clear search field
102be76 
Closes #121.

Problem:

Users cannot clear their search
unless they re-submit the search with an empty field,
or click on the resource link in the navigation bar.

Solution:

Add a button for clearing out the search field
and going back to showing all resources.
@c-lliope c-lliope added the ready label Nov 8, 2015
@c-lliope c-lliope changed the title Issue: Clearing Search Feature Request: Clearing Search Nov 12, 2015
@c-lliope c-lliope removed the ready label Nov 12, 2015
@c-lliope c-lliope mentioned this issue Nov 21, 2015
Closed
danbee pushed a commit that referenced this issue Sep 28, 2016
@c-lliope @danbee
Add button to clear search field
1b73aad 
Closes #121.

Problem:

Users cannot clear their search
unless they re-submit the search with an empty field,
or click on the resource link in the navigation bar.

Solution:

Add a button for clearing out the search field
and going back to showing all resources.
danbee pushed a commit that referenced this issue Sep 28, 2016
@c-lliope @danbee
Add button to clear search field
85788df 
Closes #121.

Problem:

Users cannot clear their search
unless they re-submit the search with an empty field,
or click on the resource link in the navigation bar.

Solution:

Add a button for clearing out the search field
and going back to showing all resources.
fwolfst pushed a commit to fwolfst/administrate that referenced this issue Mar 8, 2017
@c-lliope @fwolfst
Add button to clear search field
8e701e5 
Closes thoughtbot#121.

Problem:

Users cannot clear their search
unless they re-submit the search with an empty field,
or click on the resource link in the navigation bar.

Solution:

Add a button for clearing out the search field
and going back to showing all resources.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@c-lliope @ACPK