Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Destroy button not fit on the page when Layout is Responsive #1699

Closed
edimossilva opened this issue Jul 6, 2020 · 2 comments · Fixed by #1701
Closed

Destroy button not fit on the page when Layout is Responsive #1699

edimossilva opened this issue Jul 6, 2020 · 2 comments · Fixed by #1701
Labels
feature new functionality that’s not yet implemented views-and-styles how administrate looks and is interacted with

Comments

@edimossilva
Copy link
Contributor

edimossilva commented Jul 6, 2020 •
edited
Loading

  • Scenario

    • On show resource page, when the layout is responsive and the column labels have many letters

  • Issue

    • Destroy button not fit on the page.

  • Example

    • image

  • Proposal

    • Increase the min-width to .main-content

  • What versions are you running?

    • Rails - 6.0.0
    • administrate - 0.14.0
@edimossilva edimossilva added the bug breakages in functionality that is implemented label Jul 6, 2020
@nickcharlton
Copy link
Member

Administrate's layout doesn't try to be responsive to different browser widths and so far it's not been something that's been prioritised above other work.

…however it is something I'd like to get fixed, so thanks for opening this!

Do you think you'd be able to open a PR with your suggested fix?

@nickcharlton nickcharlton added feature new functionality that’s not yet implemented views-and-styles how administrate looks and is interacted with and removed bug breakages in functionality that is implemented labels Jul 6, 2020
@edimossilva
Copy link
Contributor Author

Hi @nickcharlton, yes, I will create a PR.

@edimossilva edimossilva mentioned this issue Jul 7, 2020
Closed
edimossilva added a commit to edimossilva/administrate that referenced this issue Jul 7, 2020
@edimossilva
thoughtbot#1699 - add min-width to main-content
44eb1c4
edimossilva added a commit to edimossilva/administrate that referenced this issue Jul 7, 2020
@edimossilva
thoughtbot#1699 - add min-width to main-content
c26e446
edimossilva added a commit to edimossilva/administrate that referenced this issue Jul 7, 2020
@edimossilva
thoughtbot#1699 - add min-width to main-content
2a012fd
edimossilva added a commit to edimossilva/administrate that referenced this issue Jul 7, 2020
@edimossilva
thoughtbot#1699 - add min-width to main-content
73bbebe
edimossilva added a commit to edimossilva/administrate that referenced this issue Jul 7, 2020
@edimossilva
thoughtbot#1699 - add min-width to main-content
e0531d2
@edimossilva edimossilva mentioned this issue Jul 7, 2020
Merged
edimossilva added a commit to edimossilva/administrate that referenced this issue Jul 8, 2020
@edimossilva
thoughtbot#1699 - increase percentage for attribute label
dfbfc8f
edimossilva added a commit to edimossilva/administrate that referenced this issue Jul 8, 2020
@edimossilva
thoughtbot#1699 - add min-width to main-content
a712223
pablobm pushed a commit that referenced this issue Jul 23, 2020
@edimossilva
#1699 - add min-width to main-content (#1701)
bf5a786
edimossilva added a commit to edimossilva/administrate that referenced this issue Aug 18, 2020
@edimossilva
thoughtbot#1699 - add min-width to main-content (thoughtbot#1701)
88a122b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature new functionality that’s not yet implemented views-and-styles how administrate looks and is interacted with
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add min-width to main-content edimossilva/administrate
2 participants
@nickcharlton @edimossilva