Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

autoprefixer-rails is deprecated #1733

Closed
nickcharlton opened this issue Aug 3, 2020 · 2 comments
Closed

autoprefixer-rails is deprecated #1733

nickcharlton opened this issue Aug 3, 2020 · 2 comments
Labels
dependencies changes or issues relating to a dependency frontend-pipeline Webpacker vs Sprockets maintenance to keep up with changes around us views-and-styles how administrate looks and is interacted with

Comments

@nickcharlton
Copy link
Member

As of today (2020-08-03), autoprefixer-rails is deprecated.

The suggested upgrade path is to move it into frontend dependencies (which would assume we were using webpacker everywhere, ala the frontend-pipeline group of issues). But, I wonder if we can just remove it and inline any prefixes?
@nickcharlton nickcharlton added views-and-styles how administrate looks and is interacted with dependencies changes or issues relating to a dependency maintenance to keep up with changes around us frontend-pipeline Webpacker vs Sprockets labels Aug 3, 2020
@sedubois
Copy link
Contributor

autoprefixer-rails has been un-deprecated.

nickcharlton pushed a commit to EWright212/administrate that referenced this issue Sep 17, 2020
@EWright212 @KOlofinmoyin @nickcharlton
Remove autoprefixer
0aa02c7 
* Autoprefixer was deprecated on 2020-08-03, but later undeprecated,
* But we don't need it for anything important in our CSS.

Closes thoughtbot#1733

Co-authored-by: Kehinde Olofinmoyin <Kehindeolofinmoyin@hotmail.com>
@pablobm
Copy link
Collaborator

pablobm commented Sep 24, 2020

Re: the "un-deprecation" - You have to be kidding me! 😆

Still, it's a dependency that had very little use, so I think it will save us trouble in the future if we just remove it, as we just did.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
dependencies changes or issues relating to a dependency frontend-pipeline Webpacker vs Sprockets maintenance to keep up with changes around us views-and-styles how administrate looks and is interacted with
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nickcharlton @pablobm @sedubois