Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The 'Adding Controllers without a related Model' page, does NOT display the page title as a prefix to '- Administrate'. #1741

Closed
KOlofinmoyin opened this issue Aug 14, 2020 · 0 comments · Fixed by #1742
Closed

The 'Adding Controllers without a related Model' page, does NOT display the page title as a prefix to '- Administrate'. #1741

KOlofinmoyin opened this issue Aug 14, 2020 · 0 comments · Fixed by #1742
Labels
bug breakages in functionality that is implemented documentation how to use administrate, examples and common usage

Comments

@KOlofinmoyin
Copy link
Contributor

Repro steps:

  1. Navigate to https://administrate-demo-prerelease.herokuapp.com/adding_controllers_without_related_model
  2. View/ inspect the browser tab for the current page _title
    Adding controller without related model is NOT prefixed with page name
    _.

Expected behaviour:

  1. The tab has the label 'Adding Controllers without a related Model - Administrate'

Actual behaviour:

  1. The tab has the label '** - Administrate**' (image attached).
  • What versions are you running?
    • Rails 6.0.3.2
    • administrate 0.14.0
@KOlofinmoyin KOlofinmoyin added the bug breakages in functionality that is implemented label Aug 14, 2020
@KOlofinmoyin KOlofinmoyin changed the title The 'Adding Controllers without a related Model' page, does NOT display the page name as a prefix to '- Administrate'. The 'Adding Controllers without a related Model' page, does NOT display the page title as a prefix to '- Administrate'. Aug 14, 2020
@nickcharlton nickcharlton added the documentation how to use administrate, examples and common usage label Aug 14, 2020
nickcharlton added a commit that referenced this issue Aug 14, 2020
@nickcharlton
Add missing title to Without Related Model doc
d2f9d56 
Fixes #1741
@nickcharlton nickcharlton mentioned this issue Aug 14, 2020
Merged
nickcharlton added a commit that referenced this issue Aug 14, 2020
@nickcharlton
Add missing title to Without Related Model doc (#1742)
9a23c58 
Fixes #1741
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug breakages in functionality that is implemented documentation how to use administrate, examples and common usage
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add missing title to Without Related Model doc thoughtbot/administrate
2 participants
@nickcharlton @KOlofinmoyin