Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dependency on bourbon not listed #615

Closed
pedantic-git opened this issue Jun 22, 2016 · 10 comments
Closed

Dependency on bourbon not listed #615

pedantic-git opened this issue Jun 22, 2016 · 10 comments
Labels
bug breakages in functionality that is implemented

Comments

@pedantic-git
Copy link
Contributor

After upgrading to administrate 0.2.2 (from 0.2.0) my app started throwing:

File to import not found or unreadable: bourbon.
[snip]
./app/views/layouts/application.html.haml:8:in `_app_views_layouts_application_html_haml___2930206960703904785_47038691733580'

This was fixed by adding the 'bourbon' gem to my Gemfile, but I feel it should properly be included in administrate's dependencies instead.
emillon added a commit to emillon/secret-santa that referenced this issue Jun 30, 2016
@emillon
Manually install bourbon (thoughtbot/administrate#615)
2970fa2
@fourcolors
Copy link

Thanks @pedantic-git I just ran into this issue today and was trying to figure out why paths from my images were not there. This saved me some time 👍

@pedantic-git
Copy link
Contributor Author

@fourcolors It looks like it's fixed in the master branch now, so hopefully in the next release we can drop this.

@fourcolors
Copy link

@pedantic-git Thanks again!

@JoelQ JoelQ added the bug breakages in functionality that is implemented label Oct 7, 2016
@JoelQ
Copy link
Contributor

JoelQ commented Oct 7, 2016

@danbee can you confirmed that this has been fixed? If so I think we can close the issue.

@JoelQ JoelQ mentioned this issue Oct 7, 2016
Closed
@pcantrell
Copy link

It’s not currently fixed on the master branch.

@pkoch
Copy link

pkoch commented Oct 19, 2016

I solved this by adding require 'bourbon' in my config/application.rb.

What would be the right way to fix this on master?

@kpheasey kpheasey mentioned this issue Oct 20, 2016
Closed
kpheasey pushed a commit to kpheasey/administrate that referenced this issue Oct 20, 2016
administrate engine requires bourbon. fixes thoughtbot#615
e798827
This was referenced Oct 28, 2016
Closed
Closed
kpheasey pushed a commit to kpheasey/administrate that referenced this issue Oct 28, 2016
administrate engine requires bourbon. fixes thoughtbot#615
ad6da51
kpheasey pushed a commit to kpheasey/administrate that referenced this issue Oct 28, 2016
administrate engine requires bourbon. fixes thoughtbot#615
b0ef51c
kpheasey pushed a commit to kpheasey/administrate that referenced this issue Oct 28, 2016
administrate engine requires bourbon. fixes thoughtbot#615
24b17dd
kpheasey pushed a commit to kpheasey/administrate that referenced this issue Oct 28, 2016
administrate engine requires bourbon. fixes thoughtbot#615
5b9881e
kpheasey pushed a commit to kpheasey/administrate that referenced this issue Oct 28, 2016
@ianagne
Update Field .with_options Documentation
5db8dff 
Per [issue thoughtbot#647], documentation does not contain possible options to set
for fields via .with_options.

* Add possible options for Field::HasMany, Field::Number, Field::Select,
Field::String, and Field::Text
* Remove :multiplier and :title options from Field::Number.with_options
example, as they are not yet implemented (see [issue thoughtbot#292])

[issue thoughtbot#647]: thoughtbot#647
[issue thoughtbot#292]: thoughtbot#292

ignore rubymine files

administrate engine requires bourbon. fixes thoughtbot#615

Revert "ignore rubymine files"

This reverts commit 4d82e06.

administrate engine requires bourbon. fixes thoughtbot#615

ignore rubymine files
kpheasey pushed a commit to kpheasey/administrate that referenced this issue Oct 28, 2016
administrate engine requires bourbon. fixes thoughtbot#615
5e2d11f
@seraph
Copy link

seraph commented Oct 28, 2016

I just encountered this bug on Rails 5, fresh app with a single model. I resolved it by adding bourbon to my Gemfile directly, and bundling.

@pkoch
Copy link

pkoch commented Oct 31, 2016 •
edited
Loading

To fix this, either put bourbon in your Gemfile or require 'bourbon' somewhere in your initializers. Something like @kpheasey's patch should eventually be added to administrate to fix this for good.

dmshvetsov pushed a commit to dmshvetsov/administrate_try that referenced this issue Nov 5, 2016
Fix bourbon dependency error
2befb81 
File to import not found or unreadable: bourbon.
thoughtbot/administrate#615
@stratigos stratigos mentioned this issue Dec 17, 2016
Closed
nickcharlton pushed a commit that referenced this issue Dec 20, 2016
@kpheasey @nickcharlton
administrate engine requires bourbon. fixes #615 (#683)
576976a
@brandonweiss
Copy link

brandonweiss commented Feb 19, 2017 •
edited
Loading

@nickcharlton No new release yet?

fwolfst pushed a commit to fwolfst/administrate that referenced this issue Mar 8, 2017
@kpheasey @fwolfst
administrate engine requires bourbon. fixes thoughtbot#615 (thoughtbo…
1d65b9d 
…t#683)
@ACPK
Copy link

ACPK commented Aug 2, 2019

@nickcharlton - This issue still seems to be a problem for a new install that uses the latest version (0.0.11).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug breakages in functionality that is implemented
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
8 participants
@brandonweiss @pkoch @seraph @fourcolors @pcantrell @pedantic-git @JoelQ @ACPK