Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move the prototype/spec referenced images to a single, reliable source. #819

Closed
nickcharlton opened this issue Apr 4, 2017 · 1 comment · Fixed by #933
Closed

Move the prototype/spec referenced images to a single, reliable source. #819

nickcharlton opened this issue Apr 4, 2017 · 1 comment · Fixed by #933
Milestone

Comments

@nickcharlton
Copy link
Member

It was pointed out by @BenMorganIO that we're loading a bunch of resources in from various places, when they saw a test failure:

Capybara::Poltergeist::StatusFailError:
  Request to 'http://127.0.0.1:37179/admin/products' failed to reach server, check DNS and/or server status - Timed out with the following resources still waiting https://cdn.recombu.com/mobile/images/news/M11370/1264769196_w670.jpg
  # ./spec/features/products_index_spec.rb:17:in `block (2 levels) in <top (required)>'
  # ./spec/support/background_jobs.rb:14:in `block (3 levels) in <top (required)>'
  # ./spec/support/background_jobs.rb:5:in `run_background_jobs_immediately'
  # ./spec/support/background_jobs.rb:13:in `block (2 levels) in <top (required)>'

We should move these to a single location, and maybe stub them out for tests to absolve us of remote dependencies.

@pustomytnyk
Copy link
Contributor

@nickcharlton there is related option in docs for Capybara::Poltergeist::Driver:

:phantomjs_options (Array) - Additional command line options to be passed to PhantomJS, e.g. ['--load-images=no', ...

but I didn't try it.

@nickcharlton nickcharlton modified the milestone: v0.8.0 May 8, 2017
@nickcharlton nickcharlton modified the milestones: v0.8.0, v0.9.0 Jul 14, 2017
nickcharlton added a commit that referenced this issue Jul 14, 2017
This fixes #819 by bringing the images all under our own S3 account.
nickcharlton added a commit that referenced this issue Jul 14, 2017
This fixes #819 by bringing the images all under our own S3 account.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants