Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Albanian two-letter code to "sq" as per ISO 639-1 #1165

Merged
merged 1 commit into from
Mar 21, 2020
Merged

Change Albanian two-letter code to "sq" as per ISO 639-1 #1165

merged 1 commit into from
Mar 21, 2020

Conversation

pustomytnyk
Copy link
Contributor

It would be logical if language codes correspond ISO 639-1.

@nickcharlton
Copy link
Member

Do you know if there's a reason that it was originally al?

@nickcharlton nickcharlton added bug breakages in functionality that is implemented i18n translations and language support labels Jan 2, 2020
@pablobm
Copy link
Collaborator

pablobm commented Mar 5, 2020

Looks like al is the code for the country, while sq is the code for the language. No idea of how this plays into locales.

Looking at https://www.oracle.com/java/technologies/javase/jdk8-jre8-suported-locales.html, I see that the language tag is sq-AL. Comparing this with something else like es-AR, then I would infer that sq is the correct one to go with. But I can't tell for certain.

The original author of this file is @acelina (see #1117). I wonder if he could shed some light into this?

@acelina
Copy link
Contributor

acelina commented Mar 5, 2020

Hello. Yes, correct one to go is sq. That's the ISO code for the language. Apologies for the mistake that slipped through.

@pablobm
Copy link
Collaborator

pablobm commented Mar 6, 2020

Thank you. @pustomytnyk, would you be able to rebase and push this? The build failed, and I think it's just a glitch that has been solved since.

@pablobm
Copy link
Collaborator

pablobm commented Mar 21, 2020

OK, I tried running CI of this on my repo and it passed, so I'm going to try and merge this 🤞

@pablobm pablobm merged commit fcc22a9 into thoughtbot:master Mar 21, 2020
@pablobm
Copy link
Collaborator

pablobm commented Mar 21, 2020

That worked! :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug breakages in functionality that is implemented i18n translations and language support
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants