Use Show Page Attributes When Rendering a has_one Relationship On Another Record's Show Page #1259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickcharlton
added
feature
On the show page for a record, we were previously displaying the form attributes when rendering the child of a has_one relationship. This makes us display the show page attributes, fitting better when rendering a record on a show page. Furthermore, using the form attributes can lead to displaying odd attributes such as "Password Confirmation".
|
Thanks for your contribution and I'm sorry that it took so long before we got around to merging it! |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When rendering a
has_onerelationship on the show page for a record, we're presently displaying the form attributes of the child record (as defined in theFORM_ATTRIBUTESconstant from the child record's dashboard file).I think it makes more sense to use the child record's show page attributes (as defined in the
SHOW_PAGE_ATTRIBUTESconstant from the child record's dashboard file). That just fits better when rendering a record on a show page.Furthermore, using the form attributes can lead to displaying odd attributes such as "Password Confirmation".
This pull request makes the necessary changes to use the show page attributes of the child record instead of the form attributes.
It also makes use of the
render_fieldhelper to render each field a little more nicely than the raw data rendering we're doing right now.Current
Changed by This Pull Request
