Fix dashboard generator for attributes that are neither reflections nor columns #1290
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houndci-bot
reviewed
Feb 23, 2019
houndci-bot
reviewed
Mar 8, 2019
| # Attributes is a rails 5 feature | ||
| if ActiveRecord.version >= Gem::Version.new(5) | ||
| it "skips temporary attributes" do | ||
| begin |
There was a problem hiding this comment.
Style/RedundantBegin: Redundant begin block detected.
There was a problem hiding this comment.
no it's not for ruby <= 2.5
|
ruby 2.2 and 2.3 fails are not caused by my changes |
|
This solves the same issue as #1100 for me on a project I'm integrating with which used I'm going to shortly drop older than Ruby 2.4 support, so I'm just going to ignore those failures (and drop that Thanks for your PR! |
Rails allows for custom attributes, and these are often used with gems such as `attr_encrypted`. Previously, the Dashboard generator would fail with: > undefined method `has_one?' for nil:NilClass (NoMethodError) Instead of failing with an error, this ensures we rely on column names instead of attributes names.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rails allow to define custom attribute. It's usually used for coersion but nothing prevents me to use it as attr_accessor. For such cases generator was failing with
undefined method 'has_one?' for nil:NilClass (NoMethodError)With this fix generator doesn't try to define what's that and relies on column names instead of attribute names.