Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix warning messages #1334

Merged
merged 2 commits into from
Apr 28, 2019
Merged

Fix warning messages #1334

merged 2 commits into from
Apr 28, 2019

Conversation

jonatasrancan
Copy link
Contributor

  • Fix warning message related to the seed file
NOTE: Faker::LordOfTheRings.character is deprecated; use Faker::Movies::LordOfTheRings.character instead. It will be removed on or after 2019-01-01.
Faker::LordOfTheRings.character called from .../administrate/spec/example_app/db/seeds.rb:51
  • Fix warning message relate to style
autoprefixer: administrate/app/assets/stylesheets/administrate/application.scss:1934:3: Replace text-decoration-skip: ink to text-decoration-skip-ink: auto, because spec had been changed

houndci-bot
houndci-bot reviewed Apr 26, 2019
View reviewed changes
app/assets/stylesheets/administrate/base/_typography.scss
@@ -23,7 +23,7 @@ p {

a {
color: $action-color;
text-decoration-skip: ink;
text-decoration-skip-ink: auto;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unknown property text-decoration-skip-ink

@composerinteralia
Copy link
Contributor

I just ran into these warnings today. Thanks for fixing.

@composerinteralia composerinteralia merged commit 1640176 into thoughtbot:master Apr 28, 2019
@maestromac maestromac mentioned this pull request May 23, 2019
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@houndci-bot houndci-bot houndci-bot left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jonatasrancan @composerinteralia @houndci-bot