-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a "back" link to the navigation #1376
Conversation
@tysongach, as someone who's worked on the design here quite a bit, I'd love some input on how to improve this link. Currently, it looks like: But it feels to me that the location of the text here is wrong. What do you think? |
@nickcharlton If it were me I would more clearly separate this function away from the other items, as it is a contextually destructive (it tears you away from Administrate completely) action. Perhaps try a style closer to a button, vertically align it to the main heading, and then add whitespace below to clearly separate the items: In this image I've mocked an alternative button style that may not exist in the styling, but It's fairly important that this isn't too bold or distracting, in my opinion. I'd also like to see a 'back arrow' button inside it, but that's a nice-to-have, for sure. |
31f8cd9
to
8c9e95f
Compare
I've made those changes (trying to make it fit as well as I can into Administrate). What do you think? https://administrate-demo-prer-pr-1376.herokuapp.com/admin |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
a7a0ed3
to
131bfbb
Compare
This solves half of #271 by implementing a link to take the user back to the main application. It's assumed that `root_url` without a namespace returns the main application's root.
131bfbb
to
1f7cbbd
Compare
NB: the README's screenshot does not include this change. |
Oh thanks for pointing that out! I did that here: #1523 |
This solves half of #271 by implementing a link to take the user back to
the main application. It's assumed that
root_url
without a namespacereturns the main application's root.