Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a "back" link to the navigation #1376

Merged
merged 1 commit into from
Jan 7, 2020
Merged

Conversation

nickcharlton
Copy link
Member

This solves half of #271 by implementing a link to take the user back to
the main application. It's assumed that root_url without a namespace
returns the main application's root.

@nickcharlton
Copy link
Member Author

@tysongach, as someone who's worked on the design here quite a bit, I'd love some input on how to improve this link.

Currently, it looks like:

Screenshot 2019-07-12 at 15 32 09

But it feels to me that the location of the text here is wrong. What do you think?

@nickcharlton nickcharlton added feature new functionality that’s not yet implemented views-and-styles how administrate looks and is interacted with labels Jan 2, 2020
@LkeMitchll
Copy link

@tysongach, as someone who's worked on the design here quite a bit, I'd love some input on how to improve this link.

Currently, it looks like:

Screenshot 2019-07-12 at 15 32 09

But it feels to me that the location of the text here is wrong. What do you think?

@nickcharlton If it were me I would more clearly separate this function away from the other items, as it is a contextually destructive (it tears you away from Administrate completely) action. Perhaps try a style closer to a button, vertically align it to the main heading, and then add whitespace below to clearly separate the items:

Screenshot 2020-01-03 at 11 32 34

In this image I've mocked an alternative button style that may not exist in the styling, but It's fairly important that this isn't too bold or distracting, in my opinion. I'd also like to see a 'back arrow' button inside it, but that's a nice-to-have, for sure.

@nickcharlton nickcharlton temporarily deployed to administrate-demo-prer-pr-1376 January 4, 2020 14:30 Inactive
@nickcharlton
Copy link
Member Author

I've made those changes (trying to make it fit as well as I can into Administrate). What do you think? https://administrate-demo-prer-pr-1376.herokuapp.com/admin

@nickcharlton nickcharlton temporarily deployed to administrate-demo-prer-pr-1376 January 4, 2020 14:37 Inactive
@nickcharlton nickcharlton temporarily deployed to administrate-demo-prer-pr-1376 January 7, 2020 14:54 Inactive
@nickcharlton nickcharlton temporarily deployed to administrate-demo-prer-pr-1376 January 7, 2020 15:04 Inactive
Copy link

@LkeMitchll LkeMitchll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nickcharlton nickcharlton temporarily deployed to administrate-demo-prer-pr-1376 January 7, 2020 16:49 Inactive
This solves half of #271 by implementing a link to take the user back to
the main application. It's assumed that `root_url` without a namespace
returns the main application's root.
@sedubois
Copy link
Contributor

sedubois commented Jan 9, 2020

NB: the README's screenshot does not include this change.

@nickcharlton
Copy link
Member Author

Oh thanks for pointing that out! I did that here: #1523

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature new functionality that’s not yet implemented views-and-styles how administrate looks and is interacted with
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants