Fix loading of Punditize
#1394
Merged
Fix loading of Punditize
#1394
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benfurber
approved these changes
Aug 2, 2019
pablobm
approved these changes
Aug 2, 2019
We were only defining the `Punditize` module if we had already defined `Pundit`. Setting `Punditize` like this broke autoloading in Rails when `Pundit` was not specified. We fixed the problem by always setting `Punditize` but keeping it empty if` Pundit` does not exist. #1339
purinkle
force-pushed
the
fix-punditize-loading
branch
from
1596651 to
df9fb3c
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were only defining the
Punditizemodule if we had already definedPundit. SettingPunditizelike this broke autoloading in Rails whenPunditwas not specified. We fixed the problem by always settingPunditizebut keeping it empty ifPunditdoes not exist.#1339