UUID's should be rendered Field::String #1404
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
tarellel
changed the title
|
Thanks! Is there a test we could add to this to ensure the change is correct and doesn't get broken in future? |
nickcharlton
added
bug
|
After having just merged a PR for showing numbers correctly, I'm going to do the same here — we'll catch any issues in the future if it goes wrong. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you're using a database with with an attribute set as UUID datatype, when generating the dashboards views you'll be presented with an exception error when visiting any of the dashboards views. When using a UUID attribute, it should be rendered in the view as a a string. This prevents raising the exception error when processing the attributes in the _collection.html.erb template with the the render_field method.