Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document controller APIs #1479

Merged
merged 5 commits into from
Dec 27, 2019

Conversation

pablobm
Copy link
Collaborator

@pablobm pablobm commented Dec 5, 2019

When reviewing #1478, it became apparent to me that controller APIs such as resource_params are not documented.

I think they should be part of Administrate's interface, and as such should be documented. Here's some documentation.

Additionally:

  • Changed the example for update so that it's more useful. The current example doesn't render or redirect, so it may cause confusion to someone trying to emulate it.
  • Mentioned requested_resource too.
  • Fixed the indent for the scoped_resource example.

@pablobm pablobm force-pushed the document-controller-apis branch from cf6f039 to 6d7a127 Compare December 19, 2019 08:01
@nickcharlton nickcharlton merged commit 0f5eed5 into thoughtbot:master Dec 27, 2019
@sedubois
Copy link
Contributor

sedubois commented Dec 29, 2019

NB: still needs to be deployed to https://administrate-prototype.herokuapp.com/customizing_controller_actions.

@pablobm pablobm deleted the document-controller-apis branch January 3, 2020 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants