Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align label and data on show page #1522

Conversation

davi-tapajos-codeminer42
Copy link
Contributor

Issue: #1213

Captura de Tela 2020-01-10 às 17 29 42

Copy link
Collaborator

@pablobm pablobm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff! One question: it looks like you have gone for baseline alignment. To me it looks a bit strange, but maybe it's just me:

Items have different height, and their typography baselines are aligned

If we are going for baselines, perhaps the label should be just one pixel further up?

Alternatively: perhaps the alignment should be centered instead? At about... 0.25em perhaps. Not sure!

Items have different height, and their typography centers are aligned

I wonder if @LkeMitchll could provide some insight?

@@ -15,6 +15,7 @@ $heading-line-height: 1.2 !default;
$base-border-radius: 4px !default;
$base-spacing: $base-line-height * 1em !default;
$small-spacing: $base-spacing / 2 !default;
$top-space: 0.39em !default;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel that top-space it a bit generic a name. Should this be something else? I guess it'll depend on whether cell-label needs to be altered (see my comment above).

@pablobm
Copy link
Collaborator

pablobm commented Jan 23, 2020

OK @davi-tapajos-codeminer42, let's see if we can see this through!

I think an opinion from a designer may take a bit to arrive, so let's see what we can fix for now. What do you think of my comment about baseline vs centre alignment?

Also, I think the name $top-space is not very descriptive. Also it may be that we don't use the same measure in both places in the end, depending on how the baseline vs centre alignment question is resolved. What do you think?

@davi-tapajos-codeminer42
Copy link
Contributor Author

I think that centre alignment will looks nice!
and yep, probably we will get rid of this $top-space :)

@pablobm
Copy link
Collaborator

pablobm commented Jan 23, 2020

Cool. Would you be able to make those changes, and I'll review again? Thank you!

@davi-tapajos-codeminer42
Copy link
Contributor Author

It is kind hard to align with "dt" and "dd" tags
Maybe in the future we could change those tags and use vertical-align to get better results

Captura de Tela 2020-01-23 às 11 49 51

@pablobm
Copy link
Collaborator

pablobm commented Jan 25, 2020

I think this is good enough for now. Thank you again @davi-tapajos-codeminer42

Fixes #1213

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants