-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test against Ruby 2.7 on CircleCI #1548
Conversation
baaa00a
to
5bc48a8
Compare
f78db13
to
1d5af25
Compare
I don't seem to be able to get this to work:
Which a) seems unrelated to adding a new Ruby version b) I can't replicate locally |
Had a look today. I cannot reproduce the issue locally either. I think it might be due to a bug in Chromium/Chromedriver v85.0.4183.102, but I can't confirm as my Linux machine runs Chromium v83, and getting v85 is a bit of a faff. For comparison, the CircleCI Ruby 2.6 image (which doesn't have this problem) runs ChromeDriver v76.0.3809.126. Fortunately, SSH'ing into CircleCI allowed me to reproduce the issue. It appears that it arises when certain other specs are run before this one. For example, if you run this:
Then you'll see that the troublesome example will fail if one of the following specs runs first:
I tried a few other things. It looks like after running a few times, Chromium/Chromedriver enters a state where this error happens. So there might be a compound effect going on... Not helpful! An idea would be to try some arbitrary ChromeDriver options, such as fullscreen or window size. Who knows what could help. |
Ah nice! The last time I tried this, I couldn't even connect to the running instance, so I'll try again and see. |
1d5af25
to
140e721
Compare
We need to install a specific bundler version so that we're doing the same in CI everywhere. Appraisal historically had issues with Bundler 2.0, but upgrading this would be an unrelated change.
dd54052
to
a5f013a
Compare
No description provided.