Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document configuration for default ordering #1635

Closed
wants to merge 1 commit into from
Closed

Document configuration for default ordering #1635

wants to merge 1 commit into from

Conversation

sedubois
Copy link
Contributor

@sedubois sedubois commented May 4, 2020

@nickcharlton nickcharlton added the documentation how to use administrate, examples and common usage label May 5, 2020
pablobm
pablobm reviewed May 8, 2020
View reviewed changes
Copy link
Collaborator

@pablobm pablobm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would it make sense to add default_sort to Administrate::ApplicationController, as part of this PR? Reading this I feel that some people may think it's already there.

@sedubois
Copy link
Contributor Author

@pablobm should this be closed in favor of #1644?

@nickcharlton
Copy link
Member

Yeah, I'm going to close this in favour of #1644 as it adds more and solves the slight weirdness we'd otherwise have with overriding bits which aren't everywhere.

Thanks!

@sedubois sedubois deleted the patch-4 branch May 12, 2020 11:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablobm pablobm pablobm left review comments

Assignees
No one assigned
Labels
documentation how to use administrate, examples and common usage
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sedubois @nickcharlton @pablobm