Recursively process nested parameters for polymorphism #1648
Conversation
|
It'd be good to have a test here. I'd suggesting going ahead with a manually built parameter hash — I can't think of a better plan. |
nickcharlton
added
bug
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
|
@nickcharlton added a spec here, verified that it failed prior to the change in ApplicationController and passes now. Let me know what you think. |
| post :create, log_entry: resource_params | ||
| rescue ActiveModel::UnknownAttributeError | ||
| # Ignore errors that arise because the parameters are contrived to | ||
| # test that nested polymorphic parameters are properly converted |
There was a problem hiding this comment.
Does this happen with this test? I wonder if there's a way around it if so
There was a problem hiding this comment.
This does happen, because the params that are being used to attempt to create a LogEntry record are fictitious and don't align with viable attributes. I'll try tossing spinning up an attr_accessor on the model, my first thought was to mock in the entire NestedHasMany logic to make those params valid but now that you ask I think there's probably a quick workaround.
There was a problem hiding this comment.
@nickcharlton attr_accessor worked great, pushed a commit up for that + hound fixes. Only hound stuff left looks ignorable (I think).
|
|
||
| LogEntry.attr_accessor :arbitrarily | ||
|
|
||
| post :create, log_entry: resource_params |
There was a problem hiding this comment.
Rails/HttpPositionalArguments: Use keyword arguments instead of positional arguments for http call: post.
There was a problem hiding this comment.
I'm happy to ignore this one.
When submitting changes to models with polymorphic nested parameters, we previously weren't handling all of the parameters through the data structure given to us. This ensures we do that by doing it recursively. Fixes nickcharlton/administrate-field-nested_has_many#38
|
Thanks for your work on this! |
Not sure what the best way to test this would be. I could manually build a parameter hash to simulate that which comes in from NestedHasMany? Or perhaps this is straightforward enough to not require specific testing?