Use singular resource name for error explanation #1649
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just a little thing I noticed.
Was:
Now:
Not sure if this is too much of a bandaid approach here. Was imagining potentially passing in the
count
option todisplay_resource_name
from the error partial view code, but if you haven't defined a translation, then thedefault
string that's constructed is what ends up being returned. Given that the default comes fromdefault_resource_name
(which pluralizes the model name), the count is often ignored for the plural version.Thoughts on if this is good enough or if a larger refactor around how
display_resource_name
is used is called for?