Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding 'Back to app' label to internationalization #1651

Merged
merged 1 commit into from
May 22, 2020
Merged

Adding 'Back to app' label to internationalization #1651

merged 1 commit into from
May 22, 2020

Conversation

edimossilva
Copy link
Contributor

@edimossilva edimossilva commented May 18, 2020 •
edited
Loading

'Back to app' label was hardcoded and now is on internationalization files

fix #1622

@edimossilva edimossilva changed the title adding Back to app to internationalization adding 'Back to app' label to internationalization May 18, 2020
@edimossilva edimossilva changed the title adding 'Back to app' label to internationalization Adding 'Back to app' label to internationalization May 18, 2020
pablobm
pablobm approved these changes May 21, 2020
View reviewed changes
Copy link
Collaborator

@pablobm pablobm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great effort!

@pablobm
Copy link
Collaborator

pablobm commented May 22, 2020

@nickcharlton - You were looking into i18n a bit more than me. Do you have any further comments?

@nickcharlton nickcharlton merged commit 997296b into thoughtbot:master May 22, 2020
@nickcharlton
Copy link
Member

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pablobm pablobm pablobm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Back to app not translated
3 participants
@edimossilva @pablobm @nickcharlton