protected visibility is discouraged
#1687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coming from other languages, it's tempting to use `protected` in Ruby. However this keyword has different nuanced in Ruby and is generally discouraged. It should only be used for methods required for comparators and operators. None of the methods marked as `protected` here fall into this category, so I think they should be marked `private` instead.
nickcharlton
approved these changes
Jun 25, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Coming from other languages, it's tempting to use
protectedin Ruby. However this keyword has different nuanced in Ruby and is generally discouraged.In Ruby, typical legitimate uses of
protectedinclude support methods for comparators and operators. None of the methods marked asprotectedhere fall into this category, so I think they should be markedprivateinstead.