Add basic validations for Product slugs #169
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Merging without review because:
|
Problem: On the demo site, it's rather simple for users to craft product names that don't translate into valid slugs. When Rails tries to render links to these products, it throws a 500 error because it cannot generate a correct URL. Solution: Add validators to ensure that all products have a valid and unique slug.
c-lliope
force-pushed
the
gw-validations
branch
from
60c4b59 to
0a92fca
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #162
Problem:
On the demo site, it's rather simple for users to craft product names
that don't translate into valid slugs.
When Rails tries to render links to these products, it throws a 500
error because it cannot generate a correct URL.
Solution:
Add validators to ensure that all products have a valid and unique slug.