Fix pagination of "Page" models #1725
Conversation
Moved other pagination-related specs to new location, to better organise specs as well as to share the helper `expect_to_appear_in_order`.
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
| expect_to_appear_in_order("Page 1", "Page 2", "Page 3") | ||
|
|
||
| click_on "Next" | ||
| expect_to_appear_in_order("Page 4", "Page 5") |
There was a problem hiding this comment.
Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
| click_on "Title" | ||
| expect_to_appear_in_order("Page 1", "Page 2", "Page 3") | ||
|
|
||
| click_on "Next" |
There was a problem hiding this comment.
Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
|
|
||
| visit admin_pages_path(per_page: 3) | ||
| click_on "Title" | ||
| expect_to_appear_in_order("Page 1", "Page 2", "Page 3") |
There was a problem hiding this comment.
Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
| FactoryBot.create(:page, title: "Page 3") | ||
|
|
||
| visit admin_pages_path(per_page: 3) | ||
| click_on "Title" |
There was a problem hiding this comment.
Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
| FactoryBot.create(:page, title: "Page 4") | ||
| FactoryBot.create(:page, title: "Page 1") | ||
| FactoryBot.create(:page, title: "Page 5") | ||
| FactoryBot.create(:page, title: "Page 3") |
There was a problem hiding this comment.
Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
| query = "bar@baz.com" | ||
|
|
||
| visit admin_customers_path(search: query) | ||
| click_on "Name" |
There was a problem hiding this comment.
Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
| end | ||
|
|
||
| it "preserves search" do | ||
| query = "bar@baz.com" |
There was a problem hiding this comment.
Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
| expect_to_appear_in_order("unique name one", "unique name two") | ||
| end | ||
|
|
||
| it "preserves search" do |
There was a problem hiding this comment.
Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
| visit admin_customers_path | ||
| 3.times { click_on "Name" } | ||
|
|
||
| expect_to_appear_in_order("unique name one", "unique name two") |
There was a problem hiding this comment.
Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
| create(:customer, name: "unique name two") | ||
|
|
||
| visit admin_customers_path | ||
| 3.times { click_on "Name" } |
There was a problem hiding this comment.
Style/StringLiterals: Prefer single-quoted strings when you don't need string interpolation or special symbols.
See thoughtbot/administrate#1725 Relevant excerpt: > Using the param :page for top-level pagination (ie: index pages as opposed to has_many lists in show pages) conflicts with paginating resources whose type happens to be "Page".
|
@stadia - Care to elaborate on what you mean by providing that link? |
See thoughtbot/administrate#1725 Relevant excerpt: > Using the param :page for top-level pagination (ie: index pages as opposed to has_many lists in show pages) conflicts with paginating resources whose type happens to be "Page".
Fixes #1709
Using the param
:pagefor top-level pagination (ie: index pages as opposed to has_many lists in show pages) conflicts with paginating resources whose type happens to be "Page".I'd rather have written a unit spec for this, instead of a whole new dashboard for the example app. However the pagination code is all over the place making this quite tricky. Ideally, we should move all the pagination code into a single module that can be tested in isolation. This in turn is not easy, as Kaminari doesn't make it easy. I'm leaving that for another day.
I have created a new feature spec called
pagination_spec.rb. Into this I have moved other pre-existing pagination examples, to help organise things, and also to take advantage of the helper methodexpect_to_appear_in_orderin the new example.