-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Namespace option view generators #1832
Conversation
expect(contents).to eq(expected_contents) | ||
end | ||
|
||
it "copies the collection partial into the `namespace/resource` namespace" do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Metrics/LineLength: Line is too long. [81/80]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't worry about this specific warning.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good 👍 If you could please fix the Hound warnings (except the one I comment separately), I think we can merge.
expect(contents).to eq(expected_contents) | ||
end | ||
|
||
it "copies the collection partial into the `namespace/resource` namespace" do |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't worry about this specific warning.
Co-authored-by: Kehinde Olofinmoyin <kehindeolofinmoyin@hotmail.com>
Co-authored-by: Kehinde Olofinmoyin <kehindeolofinmoyin@hotmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A-mergin'!
Resolves issue 1632
rails generate administrate:views:index Modelname --namespace=<Namespace>
possible. Output is