Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Namespace option view generators #1832

Merged
merged 5 commits into from
Dec 3, 2020
Merged

Namespace option view generators #1832

merged 5 commits into from
Dec 3, 2020

Conversation

RaeRachael
Copy link
Contributor

@RaeRachael RaeRachael commented Nov 25, 2020

Resolves issue 1632

  • Makes rails generate administrate:views:index Modelname --namespace=<Namespace> possible. Output is
      create  app/views/<namespace>/modelnames/index.html.erb
      create  app/views/<namespace>/modelnames/_collection.html.erb

expect(contents).to eq(expected_contents)
end

it "copies the collection partial into the `namespace/resource` namespace" do
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Metrics/LineLength: Line is too long. [81/80]

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't worry about this specific warning.

Copy link
Collaborator

@pablobm pablobm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good 👍 If you could please fix the Hound warnings (except the one I comment separately), I think we can merge.

expect(contents).to eq(expected_contents)
end

it "copies the collection partial into the `namespace/resource` namespace" do
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't worry about this specific warning.

Copy link
Collaborator

@pablobm pablobm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A-mergin'!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants