Allow different form attributes for new/update actions #1991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
where is .rubocop.yml? i can't review all errors locally? |
pablobm
reviewed
Jun 10, 2021
There was a problem hiding this comment.
Thank you for the PR @kolasss! I think it's pretty good. If you can just have a look at my comments, I think we can get this merged soon.
Regarding your question about the Rubocop config, I think Hound uses the rules found at https://github.com/thoughtbot/guides/blob/main/ruby/.rubocop.yml
Co-authored-by: Pablo Brasero <36066+pablobm@users.noreply.github.com>
|
This thing looks like I would need - is there any plan on making next gem release? Current |
jordan-brough
pushed a commit
to rinsed-org/administrate
that referenced
this pull request
Jan 21, 2022
Co-authored-by: Pablo Brasero <36066+pablobm@users.noreply.github.com>
jordan-brough
added a commit
to rinsed-org/administrate
that referenced
this pull request
Jan 24, 2022
…) (#24) Co-authored-by: Pablo Brasero <36066+pablobm@users.noreply.github.com> Co-authored-by: Nikolai Ammosov <kolas.batman@gmail.com> Co-authored-by: Pablo Brasero <36066+pablobm@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.