Refactor page redirect path after 'destroy', 'create', 'update' #1995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
edimossilva
force-pushed
the
refactor-page-redirect-path-after-destroy-create-edit
branch
from
ef3bf08 to
f606d8d
Compare
![hound[bot]](https://avatars.githubusercontent.com/in/3598?s=60&v=4){kind=small}
edimossilva
force-pushed
the
refactor-page-redirect-path-after-destroy-create-edit
branch
2 times, most recently
from
93f12b8 to
554e6af
Compare
edimossilva
force-pushed
the
refactor-page-redirect-path-after-destroy-create-edit
branch
from
554e6af to
cfade80
Compare
pablobm
reviewed
Jun 10, 2021
edimossilva
force-pushed
the
refactor-page-redirect-path-after-destroy-create-edit
branch
from
3390b33 to
ce3433f
Compare
this will make us easier to override redirect path fix syntax fix hound restore unchanged lines fix hound review Update application_controller.rb fix hound review Add specs and doc for override redirect feature Update docs/customizing_controller_actions.md Co-authored-by: Pablo Brasero <36066+pablobm@users.noreply.github.com> use anonimous controller for custom redirect
edimossilva
force-pushed
the
refactor-page-redirect-path-after-destroy-create-edit
branch
from
ce3433f to
c3c0568
Compare
I've done the suggested changes, please review again @pablobm |
|
Thank you @edimossilva! Incidentally, I found what was wrong with those Hound errors on |
edimossilva
deleted the
refactor-page-redirect-path-after-destroy-create-edit
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@pablobm , please review
This is a follow-up of PR #1973
Should I squash the commits?
hound is complaining about something but I think it is not relevant, and maybe this rule should be disabled => rubocop/rubocop#3675