Only allow HTTP(S) URLs in example app #2003
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nickcharlton
approved these changes
Jun 17, 2021
| :product, | ||
| image_url: "\n https://example.com/foo/bar \n", | ||
| ) | ||
| product = Product.create(attrs) |
There was a problem hiding this comment.
Suggested change
| product = Product.create(attrs) | |
| it "is trimmed on save" do | |
| product = create( | |
| :product, | |
| image_url: "\n https://example.com/foo/bar \n", | |
| ) |
I don't seem to be able to get the suggestion to work out, but I hope you get the idea 😅
What do you think about collapsing all of these together?
There was a problem hiding this comment.
Yeah, I don't know why I went with that. It's something about FactoryBot not doing anything clever behind my back, but it's a bit silly. OK, I'll fix it 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We may want to clean the example app's DB after merging this.