Enable to pass html options to URL field

[shouichi]

Close #2134.

[nickcharlton]

This looks good!

One thought though: Do you think we could move the options up to the Base class so that it applies to all fields?

[shouichi]

One thought though: Do you think we could move the options up to the Base class so that it applies to all fields?

Sounds cool! I searched the codebase (git grep content_tag) and found that only Fields::Url uses content_tag. The templates of some fields are somewhat non-trivial. It might not be obvious where the html_options applies to. I believe we can gradually add html_options to certain fields, then introduce it to the base class when we find it useful (and we can do that in a backward-compatible way I guess). What do you think?

By the way, I realized that I also needed to change _index.html.erb template too. I'll fix it tomorrow.

Thanks!

[nickcharlton]

Thanks for updating!

Yes, I think we can leave it as just the URL field for now and expand it over time.