Consistent custom dashboards #2184
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pablobm
commented
Apr 28, 2022
| end | ||
|
|
||
| def resource(resource_name) | ||
| define_singleton_method(:named_resource) { resource_name } | ||
| @named_resource = resource_name |
There was a problem hiding this comment.
This change is not strictly necessary, but I felt that the current code was needlessly complicated and could be simplified like this.
pablobm
commented
Apr 28, 2022
| <br> | ||
| <p><b>Total Orders:</b> <%= @stats[:order_count] %></h1> | ||
| <p><b>Total Customers:</b> <%= @stats[:customer_count] %></p> | ||
| <p><b>Total Orders:</b> <%= @stats[:order_count] %></p> |
pablobm
commented
Apr 28, 2022
|
|
||
| <div style="padding: 20px"> | ||
| <div> |
There was a problem hiding this comment.
The example is copied straight from spec/example_app/app/views/admin/stats/index.html.erb. I have removed the padding because it's not relevant here.
|
Bringing this back to draft as I have to rethink it. |
|
Looks like I don't need any of this in the end. Closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Working on #1941, I noticed that model-less dashboards (also known as "custom dashboards") do not behave very consistently. Eventually I found myself having to fix this before I could work on the former PR.
There are some twists and turns in the code that handles them:
HomesPolicy) instead of singular like for any other resource.StatsDashboarddeclaresresource "Stats", which is a weird mix of singular and plural (in the end it doesn't seem to matter which one you use here).This PR introduces consistency, not fixing point 1 but at least addressing the other points and allowing me to proceed with my work at #1941. Original I was going to bundle it as part of the larger PR, but I thought it deserved scrutiny enough to have its own one.
As for the issue with singular names, this looks like a larger problem that should be looked into with more time, and it's probably related to how we currently can't generate dashboards for singular resources.