Correct grammar on German error messages #2186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are two changes, the first is simply adding a translation for the word 'error'.
The second improves on the grammar for notifying the user of errors.
The string "%{pluralized_errors} haben das Speichern dieses %{resource_name} verhindert:" is not always grammatically correct. That would depend on the amount of errors. The word "haben" has a singular and a plural form. The singular, for one error, needs to be "hat".
Also the `resource_name` would need to have a different grammatical case => "Genetiv".
To prevent adding logic to solve this, I rewrote the sentence to be simpler and always fit.
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are two changes, the first is simply adding a translation for the word 'error'.
The second improves on the grammar for notifying the user of errors.
The string "%{pluralized_errors} haben das Speichern dieses %{resource_name} verhindert:" is not always grammatically correct. That would depend on the amount of errors. The word "haben" has a singular and a plural form. The singular, for one error, needs to be "hat".
Also the
resource_namewould need to have a different grammatical case => "Genitiv".To prevent adding logic to solve this, I rewrote the sentence to be simpler and always fit.