Dart-sass compatibility #2198
Merged
Dart-sass compatibility #2198
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When updating to dartsass-rails (to replace the deprecated sassc-rails), and get my hands on some SCSS module hawtness, SASS issues deprecation warnings that look like this: ``` Deprecation Warning: Using / for division outside of calc() is deprecated and will be removed in Dart Sass 2.0.0. Recommendation: math.div($base-spacing, 2) or calc($base-spacing / 2) ``` The easy fix, while maintaining backwards compatibility, is multiply by 0.5 instead of dividing by two -- that syntax works effectively in dart-sass as well as sassc
|
The existing tests cover this change, which is effectively neutral with regards to the compiled CSS output. Also, note that this is orthogonal to #2148 since it's not about what Administrate is using to compile assets, but rather it's about what the host app is using. :) |
|
Indeed, I don't think this needs to wait for the other situation to resolve. Thank you for the simple PR! |
|
You're very welcome! Thank you for all the work you do on administrate! 😀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When updating to dartsass-rails (to replace the deprecated sassc-rails), and get my hands on some SCSS module hawtness, SASS issues deprecation warnings that look like this:
The easy fix, while maintaining backwards compatibility, is multiply by 0.5 instead of dividing by two -- that syntax works effectively in dart-sass as well as sassc.