Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle custom pagination for has_many #2258

Merged
merged 1 commit into from
Sep 29, 2022

Conversation

dwilkie
Copy link
Contributor

@dwilkie dwilkie commented Aug 30, 2022

This PR handles handles pagination for has_many.

Related to:

#2239
#2216

Sorry I missed this when submitting the above PR.

Copy link

@bigchickenwings bigchickenwings left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @dwilkie!
Thank you for your work! These changes seem to be well made and working perfectly fine!

@pablobm
Copy link
Collaborator

pablobm commented Sep 29, 2022

🚢 🇮🇹

@pablobm pablobm merged commit a2f4ce7 into thoughtbot:main Sep 29, 2022
@dwilkie dwilkie deleted the handle_custom_pagination_in_show branch September 30, 2022 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants