Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example app: change float column types to decimal #2408

Merged
merged 1 commit into from
Aug 11, 2023

Conversation

davqasd
Copy link
Contributor

@davqasd davqasd commented Aug 2, 2023

This commit fixes #2404.

@pablobm
Copy link
Collaborator

pablobm commented Aug 11, 2023

Looks good! Thank you 🙂

By the way, I had a look at why those datetimes lost their precision. This seems to be the reason: rails/rails#44358

I haven't checked, but this must be the first time we add a migration since moving to Rails 7, and consequently the first schema:dump. Therefore this change is where this behaviour manifested first.

@pablobm pablobm merged commit 412dab8 into thoughtbot:main Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Example app: don't use float types for money
2 participants